Add metrics to the native queries underpinning SQL. #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
force-pushed
the
sql-metrics-and-such
branch
from
8140730 to
66ccd29
Compare
gianm
force-pushed
the
sql-metrics-and-such
branch
4 times, most recently
from
66e6f90 to
57fec55
Compare
|
Resolved merge conflicts and force pushed, since I think nobody has looked at this yet. |
This is done by factoring out the metrics and request log emitting code from QueryResource into a new QueryLifecycle class. That class is used by both QueryResource and the SQL DruidSchema and QueryMaker. Also fixes a couple of bugs in QueryResource: - RequestLogLine start time was set to `TimeUnit.NANOSECONDS.toMillis(startNs)`, which is incorrect since absolute nanos cannot be converted to millis. - DruidMetrics.makeRequestMetrics was called with null `query` on unparseable queries, which led to spurious "Unable to log query" errors. Partial fix for apache#4047.
gianm
force-pushed
the
sql-metrics-and-such
branch
from
57fec55 to
65e5b51
Compare
I think a fix for this bug should be backported to 0.10.1 |
gianm
added a commit
to gianm/druid
that referenced
this pull request
Aug 7, 2017
A similar fix is included in apache#4561 but this patch has been cut down for the 0.10.1 branch.
fjy
pushed a commit
that referenced
this pull request
Aug 7, 2017
* QueryResource: Fix incorrect request log start times. A similar fix is included in #4561 but this patch has been cut down for the 0.10.1 branch. * Fixups
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Aug 14, 2017
* Add metrics to the native queries underpinning SQL. This is done by factoring out the metrics and request log emitting code from QueryResource into a new QueryLifecycle class. That class is used by both QueryResource and the SQL DruidSchema and QueryMaker. Also fixes a couple of bugs in QueryResource: - RequestLogLine start time was set to `TimeUnit.NANOSECONDS.toMillis(startNs)`, which is incorrect since absolute nanos cannot be converted to millis. - DruidMetrics.makeRequestMetrics was called with null `query` on unparseable queries, which led to spurious "Unable to log query" errors. Partial fix for apache#4047. * Code style * Remove unused imports. * Fix tests. * Remove unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by factoring out the metrics and request log emitting
code from QueryResource into a new QueryLifecycle class. That class
is used by both QueryResource and the SQL DruidSchema and QueryMaker.
Also fixes a couple of bugs in QueryResource:
TimeUnit.NANOSECONDS.toMillis(startNs),which is incorrect since absolute nanos cannot be converted to millis.
queryonunparseable queries, which led to spurious "Unable to log query"
errors.
Partial fix for #4047.