-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional segment load/drop management without zookeeper using http #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i inadvertently closed #4874 and couldn't re-open, hence new PR |
08d958b
to
6db6ffd
Compare
👍 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #4874
TODOs:Test on a cluster with decent load.This patch introduces following changes.
On Historical Side:
ListenableFuture SegmentLoadDropHandler.processBatch(List<DataSegmentChangeRequest>)
is added to support http endpoint for segment load/drop management.POST /druid-internal/v1/segments/changeRequests
is added in SegmentListerResource that usesListenableFuture SegmentLoadDropHandler.processBatch(List<DataSegmentChangeRequest>)
to delegate batch of load/drop requests received. Here is a copy-paste of javadoc for this endpoint.druid.segmentCache.numLoadingThreads
configuration is revived and must be greater than the"druid.coordinator.loadqueuepeon.http.batchSize
described later.On Coordinator Side:
druid.coordinator.loadqueuepeon.type
= http or curator, curator by defaultdruid.coordinator.loadqueuepeon.http.batchSize
= number of load/drop to try and process in parallel, must be less thandruid.segmentCache.numLoadingThreads
on historicaldruid.coordinator.loadqueuepeon.http.repeatDelay
= delay Duration for periodic check for new load/drop request to send to historical. note this could be very large given that same code is executed whenever a new load/drop is requested to HttpLoadQueuePeon without waiting for schedule to kick in, default 1 minutedruid.coordinator.loadqueuepeon.http.hostTimeout
= default 5 minutes, timeout used to be specified on new endpoint introduced for batch load/drop request.In the long run, I plan to remove CuratorLoadQueuePeon and ZkCoordinator. They are being kept now only to be backward compatible and for HttpLoadQueuePeon to prove itself in production.
Documentation for HttpLoadQueuePeon is intentionally left out.