Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Lower default JDBC frame size. #5409

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Feb 21, 2018

The previous default of 100,000 was a bit excessive and could easily
lead to OOM errors on "select *" style queries.

The previous default of 100,000 was a bit excessive and could easily
lead to OOM errors on "select *" style queries.
Copy link

@fmarelli fmarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure we mention this in next version release notes.

@nishantmonu51 nishantmonu51 added this to the 0.13.0 milestone Feb 21, 2018
@fjy fjy merged commit f3796bc into apache:master Feb 21, 2018
gianm added a commit to implydata/druid-public that referenced this pull request Mar 3, 2018
The previous default of 100,000 was a bit excessive and could easily
lead to OOM errors on "select *" style queries.
gianm added a commit to implydata/druid-public that referenced this pull request Mar 12, 2018
The previous default of 100,000 was a bit excessive and could easily
lead to OOM errors on "select *" style queries.
@gianm gianm deleted the sql-lower-avatica-frame-size branch September 23, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants