Splitting KafkaIndexTask for better code maintenance #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonson
changed the title
jon-wei
reviewed
Jun 15, 2018
| import javax.annotation.Nullable; | ||
| import java.util.Map; | ||
|
|
||
| final class SetEndOffsetsResult |
There was a problem hiding this comment.
this class is unused, let's remove it
There was a problem hiding this comment.
Good point. Removed it.
jon-wei
approved these changes
Jun 21, 2018
|
@jon-wei thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5771.
Added
KafkaIndexTaskRunnerand its two implementations for the legacy and the recent one. Please note that the goal of this PR is to make the non-legacy code ofKafkaIndexTaskmore understandable. There ARE a bunch of code duplication, but I think this is better than refactoring including a good abstraction.LegacyKafkaIndexTaskRunneris simply a copy ofKafkaIndexTask.runInternalLegacy()and required variables.LegacyKafkaIndexTaskRunneris expected to be removed in the future, so there is no need to put effort to make the code structure better. Also, it's easier to remove the legacy code in the future.KafkaIndexTaskbetween the legacy mode and the incremental publishing mode. A good abstraction between them requires rewriting lots of codes.This change is