ParseSpec: Remove default setting. #6310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a default ParseSpec implementation is bad for users, because it masks problems specifying the format. Two common problems masked by this are specifying the "format" at the wrong level of the JSON, and specifying a format that Druid doesn't support. In both cases, having a default implementation means that users will get the delimited parser rather than an error, and then be confused when, later on, their data failed to parse.
himanshug
approved these changes
Sep 7, 2018
|
@gianm can you check the integration tests? |
|
@fjy yes, I just fixed the ITs; a couple of the parseSpecs in there didn't specify a format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a default ParseSpec implementation is bad for users, because it masks
problems specifying the format. Two common problems masked by this are specifying
the "format" at the wrong level of the JSON, and specifying a format that
Druid doesn't support. In both cases, having a default implementation means that
users will get the delimited parser rather than an error, and then be confused
when, later on, their data failed to parse.
Marked release notes since this is a user visible behavior change. Someone relying
on the above behaviors would need to start specifying "delimited" explicitly.