Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handoff should ignore segments that are dropped by drop rules #6676

Merged
merged 8 commits into from
Jan 7, 2019
Merged

Handoff should ignore segments that are dropped by drop rules #6676

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1781afd
Handoff should ignore segments that are dropped by drop rules
Nov 28, 2018
69c432e
fix travis-ci
Nov 28, 2018
956ab63
fix tests
Nov 28, 2018
0171c69
address comments
Dec 4, 2018
ec04ec9
remove line added by accident
Dec 5, 2018
7cfbe8d
address comments
Dec 22, 2018
65d84ed
add javadoc and logging the full stack trace of exception
Jan 3, 2019
3902446
add error message
Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/src/main/java/org/apache/druid/server/http/DatasourcesResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,10 @@ public Response getSegmentDataSourceSpecificInterval(
return Response.ok(retval).build();
}

/**
* Used by the realtime tasks to learn whether a segment is handed off or not.
* It returns true when the segment will never be handed off or is already handed off. Otherwise, it returns false.
*/
@GET
@Path("/{dataSourceName}/handoffComplete")
@Produces(MediaType.APPLICATION_JSON)
Expand Down Expand Up @@ -713,6 +717,7 @@ public Response isHandOffComplete(
return Response.ok(false).build();
}
catch (Exception e) {
log.error(e, "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a proper error message like "Error while handling handoffComplete request"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

return Response.serverError().entity(ImmutableMap.of("error", e.toString())).build();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably logging the full stack trace of exception would help as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}
}
Expand Down