statsd-emitter: support constant DogStatsD tags #6791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize I didn't add a test for this feature. The other tests in StatsDEmitterTest mock out the StatsDClient, and this change is primarily a change to the construction of that object. |
nishantmonu51
approved these changes
Jan 1, 2019
| @@ -65,6 +71,7 @@ public StatsDEmitterConfig( | |||
| this.dimensionMapPath = dimensionMapPath; | |||
| this.blankHolder = blankHolder != null ? blankHolder : "-"; | |||
| this.dogstatsd = dogstatsd != null ? dogstatsd : false; | |||
| this.dogstatsdConstantTags = dogstatsdConstantTags != null ? dogstatsdConstantTags : new ArrayList<>(0); | |||
There was a problem hiding this comment.
nit: use Collections.emptyList()
| @@ -46,6 +46,7 @@ All the configuration parameters for the StatsD emitter are under `druid.emitter | |||
| |`druid.emitter.statsd.dimensionMapPath`|JSON file defining the StatsD type, and desired dimensions for every Druid metric|no|Default mapping provided. See below.| | |||
| |`druid.emitter.statsd.blankHolder`|The blank character replacement as statsD does not support path with blank character|no|"-"| | |||
| |`druid.emitter.statsd.dogstatsd`|Flag to enable [DogStatsD](https://docs.datadoghq.com/developers/dogstatsd/) support. Causes dimensions to be included as tags, not as a part of the metric name. `convertRange` fields will be ignored.|no|false| | |||
| |`druid.emitter.statsd.dogstatsdConstantFlags`|If `druid.emitter.statsd.dogstatsd` is true, the tags in the JSON list of strings will be sent with every event.|no|[]| | |||
|
Thanks, addressed both comments. |
QiuMM
reviewed
Jan 3, 2019
| @@ -53,7 +53,7 @@ static StatsDEmitter of(StatsDEmitterConfig config, ObjectMapper mapper) | |||
| config.getPrefix(), | |||
| config.getHostname(), | |||
| config.getPort(), | |||
| EMPTY_ARRAY, | |||
| config.getDogstatsd() ? config.getDogstatsdConstantTags().toArray(new String[0]) : EMPTY_ARRAY, | |||
There was a problem hiding this comment.
For boolean field, I prefer it's Getter method like isXXX, so change the StatsDEmitterConfig#getDogstatsd to StatsDEmitterConfig#isDogstatsd would be better.
There was a problem hiding this comment.
Thanks! This was a preexisting field but I changed it now. I changed hashCode to use Objects.hash too.
PR #6605 added support to the statsd emitter for DogStatsD tags. This commit lets you specify "constant tags" in the config file which are included with every event. This is helpful if you are running in an environment where you cannot configure your datadog-agent with tags like "cluster name" --- eg, a Kubernetes cluster with a datadog-agent on each node and different Druid deployments in different namespaces but sharing the same datadog-agent daemonset. Also fix the name of an existing boolean getter to start with 'is'.
QiuMM
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6605 added support to the statsd emitter for DogStatsD tags. This commit
lets you specify "constant tags" in the config file which are included with
every event. This is helpful if you are running in an environment where you
cannot configure your datadog-agent with tags like "cluster name" --- eg, a
Kubernetes cluster with a datadog-agent on each node and different Druid
deployments in different namespaces but sharing the same datadog-agent
daemonset.