fix review issue

apache · Jan 17, 2021 · bfbe4e9 · bfbe4e9
1 parent f6e0db0
commit bfbe4e9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/common/extension/metadata_service.go b/common/extension/metadata_service.go
@@ -62,6 +62,6 @@ func GetRemoteMetadataService() (service.MetadataService, error) {
 		remoteMetadataService, err = creator()
 		return remoteMetadataService, err
 	}
-	logger.Info("could not find the metadata service creator for metadataType: remote")
+	logger.Warn("could not find the metadata service creator for metadataType: remote")
 	return nil, perrors.New(fmt.Sprintf("could not find the metadata service creator for metadataType: remote"))
 }
diff --git a/metadata/service/remote/service.go b/metadata/service/remote/service.go
@@ -124,9 +124,8 @@ func (mts *MetadataService) PublishServiceDefinition(url *common.URL) error {
 				BaseMetadataIdentifier: identifier.BaseMetadataIdentifier{
 					ServiceInterface: interfaceName,
 					Version:          url.GetParam(constant.VERSION_KEY, ""),
-					// Group:            url.GetParam(constant.GROUP_KEY, constant.SERVICE_DISCOVERY_DEFAULT_GROUP),
-					Group: url.GetParam(constant.GROUP_KEY, constant.DUBBO),
-					Side:  url.GetParam(constant.SIDE_KEY, "provider"),
+					Group:            url.GetParam(constant.GROUP_KEY, constant.DUBBO),
+					Side:             url.GetParam(constant.SIDE_KEY, "provider"),
 				},
 			}
 			mts.delegateReport.StoreProviderMetadata(id, sd)

diff --git a/registry/servicediscovery/service_discovery_registry.go b/registry/servicediscovery/service_discovery_registry.go
@@ -174,10 +174,6 @@ func (s *serviceDiscoveryRegistry) Register(url *common.URL) error {
 		logger.Warnf("The URL[%s] has been registry!", url.String())
 	}
 
-	err = s.metaDataService.PublishServiceDefinition(url)
-	if err != nil {
-		return perrors.WithMessage(err, "publish the service definition failed. ")
-	}
 	return s.serviceNameMapping.Map(url.GetParam(constant.INTERFACE_KEY, ""),
 		url.GetParam(constant.GROUP_KEY, ""),
 		url.GetParam(constant.Version, ""),