Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp & Fix: issue #217 #212

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Imp & Fix: issue #217 #212

merged 4 commits into from
Sep 23, 2019

Conversation

fangyincheng
Copy link
Contributor

@fangyincheng fangyincheng commented Sep 21, 2019

What this PR does:

  1. update getty&hessian version
  2. fix bug about registryProtocol.Export
  3. fix bug for failover_cluster_invoker.go

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks
Copy link
Contributor

the title is improper. it should be "Fix: issue xxx"

@codecov-io
Copy link

Codecov Report

Merging #212 into develop will decrease coverage by 0.14%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #212      +/-   ##
===========================================
- Coverage    66.11%   65.96%   -0.15%     
===========================================
  Files           96       96              
  Lines         6455     6459       +4     
===========================================
- Hits          4268     4261       -7     
- Misses        1743     1751       +8     
- Partials       444      447       +3
Impacted Files Coverage Δ
cluster/cluster_impl/failover_cluster_invoker.go 72.34% <0%> (-6.73%) ⬇️
registry/protocol/protocol.go 81.73% <100%> (ø) ⬆️
protocol/dubbo/readwriter.go 70.37% <50%> (ø) ⬆️
protocol/jsonrpc/server.go 59.79% <0%> (-1.51%) ⬇️
remoting/zookeeper/listener.go 46.9% <0%> (-1.04%) ⬇️
remoting/zookeeper/client.go 63.87% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcbd967...7b3334e. Read the comment docs.

@fangyincheng fangyincheng changed the title update version and fix bug Imp & Fix: update version and fix bug Sep 23, 2019
@fangyincheng
Copy link
Contributor Author

the title is improper. it should be "Fix: issue xxx"

don't have this issue.Add?

@fangyincheng fangyincheng changed the title Imp & Fix: update version and fix bug Imp & Fix: issue #217 Sep 23, 2019
@AlexStocks AlexStocks merged commit 519aee1 into apache:develop Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants