Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: receive heartbeat from server #302

Merged
merged 3 commits into from
Jan 5, 2020

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

receive heartbeat package from server of java

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Jan 4, 2020

Codecov Report

Merging #302 into develop will decrease coverage by 0.08%.
The diff coverage is 45.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #302      +/-   ##
===========================================
- Coverage    65.81%   65.73%   -0.09%     
===========================================
  Files          112      112              
  Lines         7173     7182       +9     
===========================================
  Hits          4721     4721              
- Misses        1991     1998       +7     
- Partials       461      463       +2
Impacted Files Coverage Δ
protocol/dubbo/readwriter.go 68.29% <100%> (+0.39%) ⬆️
protocol/dubbo/codec.go 70.27% <28.57%> (-6.21%) ⬇️
protocol/dubbo/listener.go 50.28% <42.85%> (-0.91%) ⬇️
registry/etcdv3/registry.go 50.5% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f6377...53bb7fb. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks closed this Jan 5, 2020
@AlexStocks AlexStocks reopened this Jan 5, 2020
@AlexStocks AlexStocks merged commit 01f84dc into apache:develop Jan 5, 2020
@fangyincheng fangyincheng deleted the heartbeat_for_server branch October 29, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants