Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FailBack Registry skip retry for a long time #12592

Closed
wants to merge 1 commit into from

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 26, 2023

What is the purpose of the change

After #2752 merge, registry retry will be at most 3 times. In the case of network disconnection, Dubbo will skip to register to registry.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

77.2% 77.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov-commenter
Copy link

Codecov Report

Merging #12592 (9f6c37c) into 3.2 (2c82cf7) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12592      +/-   ##
============================================
- Coverage     69.73%   69.34%   -0.40%     
+ Complexity      318        2     -316     
============================================
  Files          3481     1625    -1856     
  Lines        164990    67329   -97661     
  Branches      27746     9890   -17856     
============================================
- Hits         115061    46689   -68372     
+ Misses        39959    16133   -23826     
+ Partials       9970     4507    -5463     

see 1875 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants