Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1245 #1374

Closed
wants to merge 3 commits into from
Closed

Fix #1245 #1374

wants to merge 3 commits into from

Conversation

hqq2023623
Copy link
Contributor

What is the purpose of the change

fix #1245

Brief changelog

fix #1245

Verifying this change

fix #1245

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

Codecov Report

Merging #1374 into master will decrease coverage by 0.15%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage   32.57%   32.42%   -0.16%     
==========================================
  Files         691      691              
  Lines       34537    34537              
  Branches     6812     6812              
==========================================
- Hits        11252    11199      -53     
- Misses      21357    21404      +47     
- Partials     1928     1934       +6
Impacted Files Coverage Δ
...libaba/com/caucho/hessian/io/JavaDeserializer.java 41.52% <14.28%> (ø) ⬆️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 71.79% <0%> (-12.83%) ⬇️
...ba/dubbo/remoting/transport/netty/NettyClient.java 72.58% <0%> (-11.3%) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) ⬇️
...mon/serialize/support/dubbo/GenericDataOutput.java 69.12% <0%> (-6.32%) ⬇️
...a/dubbo/remoting/transport/netty/NettyChannel.java 61.25% <0%> (-5%) ⬇️
...ba/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) ⬇️
...mmon/serialize/support/dubbo/GenericDataInput.java 60.23% <0%> (-3.48%) ⬇️
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java 54.54% <0%> (-2.03%) ⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java 55.22% <0%> (-1.5%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c20d99...37bf2b3. Read the comment docs.

@hqq2023623 hqq2023623 closed this Feb 19, 2018
@hqq2023623 hqq2023623 deleted the fix#1245 branch February 19, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method invokes inefficient Number constructor
2 participants