-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference retries default value #2173
Reference retries default value #2173
Conversation
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/AbstractConfig.java
update from official
Merge from official repository
@tswstarplanet Why this PR has so many commits, but just change 2 java source files? |
@diecui1202 I don't kown. It seems to contains all of the submits since I began to submit PR. But the previous PRs have been merged. Does I make some mistakes about the use of github ? |
@tswstarplanet I suggest you checkout a new branch from master, and send a new PR. How do you think? |
@diecui1202 This branch I request to merge was created from my master branch. I do not kown why it is like that. Do I need to delete my repository and fork the official repository once again ? |
@tswstarplanet Maybe your local master branch is out of date. Each branch must be created from the newest master, it's the apache/incubator-dubbo 's master, not your fork repo. |
As the above showing, I checkout to master branch, which is belongs to apache/incubator-dubbo.git, I will run After committing on the new branch, I will push it to my own repo. Then create PR. |
@diecui1202 If I create a branch from the apache/incubator-dubbo, can I commit code to my own fork and request to merge code ? |
What is the purpose of the change
Correct the default value of Reference annotation. #2162