Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization of duplicate code #2832

Closed
wants to merge 6 commits into from
Closed

optimization of duplicate code #2832

wants to merge 6 commits into from

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Optimize the duplicate code of FailbackRegistry.java.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #2832 into 2.6.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.6.x    #2832      +/-   ##
============================================
+ Coverage     47.42%   47.44%   +0.01%     
+ Complexity     4294     4292       -2     
============================================
  Files           552      552              
  Lines         24381    24381              
  Branches       4314     4314              
============================================
+ Hits          11563    11567       +4     
+ Misses        11035    11029       -6     
- Partials       1783     1785       +2
Impacted Files Coverage Δ Complexity Δ
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 54.21% <0%> (-3.62%) 13% <0%> (-2%)
...baba/dubbo/remoting/transport/mina/MinaClient.java 57.81% <0%> (-1.57%) 8% <0%> (-1%)
...onfig/spring/extension/SpringExtensionFactory.java 83.78% <0%> (+8.1%) 9% <0%> (ø) ⬇️
...a/dubbo/remoting/transport/netty/NettyChannel.java 66.25% <0%> (+8.75%) 21% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483cd7c...98e3628. Read the comment docs.

@carryxyh
Copy link
Member

The code for this part has been completely reconfigured in another PR.
If we don't accept that pr, I will handle this pr. Let it stay open first.

@CrazyHZM
Copy link
Member Author

first
Hard work,thanks.

@carryxyh
Copy link
Member

carryxyh commented Dec 3, 2018

noting changed ?

@CrazyHZM
Copy link
Member Author

CrazyHZM commented Dec 3, 2018

Sorry, I accidentally mishandled.

@CrazyHZM CrazyHZM closed this Dec 3, 2018
@CrazyHZM CrazyHZM deleted the 2.6.x branch December 3, 2018 18:49
@CrazyHZM CrazyHZM restored the 2.6.x branch December 3, 2018 19:23
@CrazyHZM CrazyHZM deleted the 2.6.x branch December 3, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants