Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade junit to junit5 #3116

Closed
wants to merge 9 commits into from
Closed

upgrade junit to junit5 #3116

wants to merge 9 commits into from

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Jan 2, 2019

What is the purpose of the change

upgrade junit to junit5

Brief changelog

test case update

Verifying this change

ci success

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@lovepoem lovepoem closed this Jan 4, 2019
@lovepoem lovepoem reopened this Jan 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #3116 into master will decrease coverage by 63.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #3116       +/-   ##
============================================
- Coverage     63.58%      0%   -63.59%     
============================================
  Files           652     652               
  Lines         28199   28199               
  Branches       4782    4782               
============================================
- Hits          17930       0    -17930     
- Misses         8014   28199    +20185     
+ Partials       2255       0     -2255
Impacted Files Coverage Δ Complexity Δ
...bo/cache/support/threadlocal/ThreadLocalCache.java 0% <0%> (-100%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/status/Status.java 0% <0%> (-100%) 0% <0%> (ø)
...g/context/properties/DefaultDubboConfigBinder.java 0% <0%> (-100%) 0% <0%> (ø)
...he/dubbo/remoting/http/servlet/ServletManager.java 0% <0%> (-100%) 0% <0%> (ø)
...p/exchange/support/MulticastExchangeNetworker.java 0% <0%> (-100%) 0% <0%> (ø)
...e/dubbo/common/serialize/fst/FstSerialization.java 0% <0%> (-100%) 0% <0%> (ø)
...va/com/alibaba/dubbo/config/ApplicationConfig.java 0% <0%> (-100%) 0% <0%> (ø)
.../java/com/alibaba/dubbo/config/ArgumentConfig.java 0% <0%> (-100%) 0% <0%> (ø)
...e/support/threadlocal/ThreadLocalCacheFactory.java 0% <0%> (-100%) 0% <0%> (ø)
...igurator/override/OverrideConfiguratorFactory.java 0% <0%> (-100%) 0% <0%> (ø)
... and 546 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb518d...9ae403e. Read the comment docs.

@lovepoem lovepoem closed this Jan 5, 2019
@lovepoem lovepoem mentioned this pull request Jan 6, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants