Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty protocol for nacos. #4294. #4349

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

cvictory
Copy link
Contributor

#4294

Nacos empty protocol

@cvictory cvictory added this to the 2.7.3 milestone Jun 19, 2019
@cvictory cvictory requested a review from mercyblitz June 19, 2019 10:49
@codecov-io
Copy link

Codecov Report

Merging #4349 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4349      +/-   ##
============================================
- Coverage     62.92%   62.85%   -0.07%     
+ Complexity      505      504       -1     
============================================
  Files           769      769              
  Lines         32995    33004       +9     
  Branches       5215     5216       +1     
============================================
- Hits          20762    20745      -17     
- Misses         9837     9858      +21     
- Partials       2396     2401       +5
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-3.07%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 71.73% <0%> (-2.18%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
...ache/dubbo/registry/multiple/MultipleRegistry.java 62.67% <0%> (-0.71%) 20% <0%> (-1%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 55.26% <0%> (+1.31%) 18% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041a6ad...f784352. Read the comment docs.

@chickenlj chickenlj changed the base branch from master to 2.7.3-release June 20, 2019 03:41
@chickenlj chickenlj merged commit a1e4757 into apache:2.7.3-release Jun 25, 2019
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants