fix(dataZoom): type fix for startValue and endValue. close #14412 #14775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
echarts-bot
bot
added
PR: awaiting doc
pissang
reviewed
May 11, 2021
| @@ -506,9 +506,12 @@ class DataZoomModel<Opts extends DataZoomOption = DataZoomOption> extends Compon | |||
|
|
|||
| setCalculatedRange(opt: RangeOption): void { | |||
| const option = this.option; | |||
| each(['start', 'startValue', 'end', 'endValue'] as const, function (name) { | |||
| each(['start', 'end'] as const, function (name) { | |||
| option[name] = opt[name]; | |||
There was a problem hiding this comment.
It's fine to use (option as any)[name] = opt[name] here to avoid writing the logic twice. Code size is also important.
pissang
approved these changes
May 12, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes Type error while using dataZoom.startValue, dataZoom.endValue
Fixed issues
Details
Before: What was the problem?
dataZoom.startValue, dataZoom.endValue supports number | string | Date but in types allowing only number. This is leading to error - Type 'string' is not assignable to type 'number'
After: How is it fixed in this PR?
Now dataZoom.startValue, dataZoom.endValue supports number | string | Date
Misc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information