dev-build: update esbuild #16619
dev-build: update esbuild #16619
Conversation
|
Thanks for your contribution! The pull request is marked to be |
| // CommonJS | ||
| factory(exports); |
There was a problem hiding this comment.
Change exports to module may behave differently in the CommonJS environment.
There was a problem hiding this comment.
As for the UMD header, it may be better to use the same block with rollup.
(function (global, factory) {
typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
typeof define === 'function' && define.amd ? define(['exports'], factory) :
(global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.echarts = {}));
}(this, (function (exports) {
// ...
})));There was a problem hiding this comment.
The reason why I have change exports to module is that esbuild generate module.exports = ___toCommonJS(****) at the end of file if we chose cjs format.
Cause in browser environment, module is not a global variable as in node. It will throw module is not defined in browser.
There was a problem hiding this comment.
@plainheart Well, Same error if we use rollup header
There was a problem hiding this comment.
JS spec is not my area of expertise. To be honestly, I'm still confused by esbuild
| @@ -142,7 +142,7 @@ | |||
| var factoryRet = factory.apply(null, deps.map(function (dep) { | |||
| return dep === exportsPlaceholder ? modExports : dep; | |||
| })); | |||
| return factoryRet || modExports; | |||
| return factoryRet || modExports.exports || modExports; | |||
There was a problem hiding this comment.
Could you explain this change to me? I think this is not same with the AMD spec
There was a problem hiding this comment.
Well, modExports would be an argument for factory function, as matter of fact, variable modExports will be variable module when function runs. Then as I have mention above, The exports attribute of module will have whatever echarts have exported.
modExports = {
exports: echarts.
}
|
|
@pissang I'm concerned about package.lock.json. Casue my lockfile version is not same with previous. I remember @plainheart have disscuess with you. |
|
@Ovilia has updated the package-lock.json to 2.0 in the release branch. Perhaps we can leave this PR to be merged after merging release to master |
Ok |
|
package-lock.json in the master branch has been updated. |
Brief Information
This pull request is in the type of:
What does this PR do?
Since
esbuilddecide to improve compatibility with Webpack and Node. After version 0.14.4, esbuild adjust the way of handling ofdefault exportsand the__esModulemarkerhttps://github.com/evanw/esbuild/releases/tag/v0.14.4
Fixed issues
Details
Before: What was the problem?
After: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information