fix(polar): fix unexpected clipping in polar coordinate #20370
Conversation
|
Thanks for your contribution! |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20370@80438d2 |
src/coord/polar/Polar.ts
Outdated
| const r = this.r; | ||
| const r0 = this.r0; | ||
|
|
||
| return d2 <= r * r && d2 >= r0 * r0; | ||
| // minus a tiny value 1e-4 in double side to avoid being clipped unexpectedly | ||
| return (d2 - 1e-4) <= r * r && (d2 + 1e-4) >= r0 * r0; |
There was a problem hiding this comment.
Please consider the scenario where r is equal to r0, in which case the data within the polar coordinates should consistently be clipped. Therefore, I recommend adding r !== r0 && as a safeguard. Additionally, to minimize redundancy, we may define a constant const epsilon = 1e-4;.
There was a problem hiding this comment.
OK got this. I will do this tody
echarts-bot
bot
added
PR: revision needed
PR: awaiting review
and removed
PR: awaiting review
labels
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
|
We sincerely appreciate your valuable contributions! We are currently running a special promotion for users who submit a Pull Request between September 25, 2024, and December 31, 2024. Eligible participants will receive a two-year enterprise membership to Baidu Comate, valued at 2000 RMB (approximately 285 USD). To learn more about this product, please visit https://comate.baidu.com/. If you are interested in this offer, kindly send an email with the link to your Pull Request along with your Comate username and email address to [email protected] to claim your membership. Thank you once again for your support! |
plainheart
changed the title
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
#20363
Details
Before: What was the problem?
The maximum value symbol in polar coordinate system scatter chart of radiusAxis is not displayed
After: How does it behave after the fixing?
Display the symbol
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information