Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] [base] fix TableId.java use identifier decode error with four quota #2443

Merged
merged 3 commits into from
Sep 7, 2023
Merged

[hotfix] [base] fix TableId.java use identifier decode error with four quota #2443

merged 3 commits into from
Sep 7, 2023

Conversation

GOODBOY008
Copy link
Member

Close #2439 .

@GOODBOY008
Copy link
Member Author

@Jiabao-Sun @ruanhang1993 @edmond-kk PTAL.

ruanhang1993
ruanhang1993 reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @GOODBOY008.
Maybe we should use

.toQuotedString('`')

instead of toString().

ruanhang1993
ruanhang1993 reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests to cover this bug. Thanks.

ruanhang1993
ruanhang1993 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanhang1993 ruanhang1993 merged commit 7801ac9 into apache:master Sep 7, 2023
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Oct 18, 2023
@GOODBOY008 @e-mhui
[cdc-base] Fix parsing error when serializing and deserializing the t…
c70cf57 
…able name with dot (apache#2443)
GOODBOY008 added a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
@GOODBOY008
[cdc-base] Fix parsing error when serializing and deserializing the t…
bd4c698 
…able name with dot (apache#2443)

(cherry picked from commit 7801ac9)
GOODBOY008 added a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
@GOODBOY008
[cdc-base] Fix parsing error when serializing and deserializing the t…
c230762 
…able name with dot (apache#2443)

(cherry picked from commit 7801ac9)
GOODBOY008 added a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
@GOODBOY008
[cdc-base] Fix parsing error when serializing and deserializing the t…
b6d87d4 
…able name with dot (apache#2443)

(cherry picked from commit 7801ac9)
leonardBang pushed a commit that referenced this pull request Oct 31, 2023
@GOODBOY008 @leonardBang
[cdc-base] Fix parsing error when serializing and deserializing the t…
4ed7206 
…able name with dot (#2443)

(cherry picked from commit 7801ac9)
zhongqishang pushed a commit to zhongqishang/flink-cdc that referenced this pull request Dec 7, 2023
@GOODBOY008 @zhongqishang
[cdc-base] Fix parsing error when serializing and deserializing the t…
c721600 
…able name with dot (apache#2443)

(cherry picked from commit 7801ac9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanhang1993 ruanhang1993 ruanhang1993 approved these changes

@Jiabao-Sun Jiabao-Sun Awaiting requested review from Jiabao-Sun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] sqlservercdc throw a NullPointerException when table name contains point
2 participants
@GOODBOY008 @ruanhang1993