[hotfix][maxcompute] Fix MaxCompute Pipeline Connector unit tests by upgrading maxcompute-emulator #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could @leonardBang trigger the CI workflow please? |
|
Seems there's still some timezone related test failures... Could @dingxin-tech please redesign the test case to make it time-zone unaware, and could run with any time-zone configuration? (We may run tests in randomized timezones in the future like #3650.) |
done. |
leonardBang
reviewed
Jan 16, 2025
| @@ -167,7 +167,7 @@ public void testRecordConvert() { | |||
| 123456.789d, | |||
| 12345, | |||
| 12345, | |||
| TimestampData.fromTimestamp(Timestamp.from(Instant.ofEpochSecond(0))), | |||
| TimestampData.fromTimestamp(Timestamp.valueOf("1970-01-01 00:00:00")), | |||
There was a problem hiding this comment.
minor: TimestampData.fromLocalDateTime is recommended
leonardBang
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failing unit tests in MaxCompute Pipeline Connector by upgrading the maxcompute-emulator dependency from 0.0.4 to 0.0.7.
Changes
maxcompute-emulatorversion in org.apache.flink.cdc.connectors.maxcompute.EmulatorTestBase