Skip to content

Commit

Permalink
[Minor] improvement(docs): Optimize Trino related docs and fix some m…
Browse files Browse the repository at this point in the history 
…inor mistakes in docs (#1152)

### What changes were proposed in this pull request?

Refine some descriptions and correct mistakes in Trino-related docs.

### Why are the changes needed?

Make users more aware of the documents.

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

N/A.
  • Loading branch information
@yuqi1129
yuqi1129 authored Dec 14, 2023
1 parent df87087 commit 4a3eca5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
10 changes: 5 additions & 5 deletions docs/trino-connector/configuration.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ license: "Copyright 2023 Datastrato Pvt Ltd.
This software is licensed under the Apache License version 2."
---

| Property | Type | Default Value | Description | Required | Since Version |
|--------------------|--------|-------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|---------------|
| connector.name | string | gravitino | The `connector.name` defines the name of Gravitino connector, this value is always 'gravitino'. | Yes | 0.2.0 |
| gravitino.metalake | string | (none) | The `gravitino.metalake` defines the metalake used. You can create it beforehand or later on. If not set, Trino might throw an error upon startup. It must be set to a valid metalake name. If it's not created, the Gravitino connector continues checking until it's created. Once created, it will load the catalogs, schemas, and tables into Trino and maintain synchronization. | Yes | 0.2.0 |
| gravitino.url | string | http://localhost:8090 | The `gravitino.url` defines the connection URL for the Gravitino server. If not set, the default value is `http://localhost:8090`. If the Gravitino server is not starting, Trino can still start normally. Once the Gravitino server is up and running, the Gravitino connector will automatically connect. You can find error details in the Trino logs. | Yes | 0.2.0 |
| Property | Type | Default Value | Description | Required | Since Version |
|--------------------|--------|-----------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------|---------------|
| connector.name | string | (none) | The `connector.name` defines the name of Trino connector, this value is always 'gravitino'. | Yes | 0.2.0 |
| gravitino.metalake | string | (none) | The `gravitino.metalake` defines which metalake in Gravitino server the Trino connector uses. Trino connector should set it at start, the value of `gravitino.metalake` needs to be a valid name, Trino connector can detect and load the metalake with catalogs, schemas and tables once created and keep in sync. | Yes | 0.2.0 |
| gravitino.url | string | http://localhost:8090 | The `gravitino.url` defines the connection URL of the Gravitino server, the default value is `http://localhost:8090`. Trino connector can detect and connect to Gravitino server once it is ready, no need to start Gravitino server beforehand. | Yes | 0.2.0 |
14 changes: 8 additions & 6 deletions docs/trino-connector/supported-catalog.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@ The catalogs currently supported by the Gravitino connector are as follows:

## Create catalog

Trino currently does not support creating Gravitino managed catalogs.
If you need to create a catalog, please refer to:
- [Create a Catalog](../manage-metadata-using-gravitino.md#create-a-catalog)
Trino currently does not support creating Gravitino managed catalogs, if you need to create a catalog, please refer to: [Create a Catalog](../manage-metadata-using-gravitino.md#create-a-catalog).

## Data type mapping between Trino and Gravitino

All types of catalogs support the following data type conversions between Trino and Gravitino:
Gravitino connector supports the following data type conversions between Trino and Gravitino currently. Depending on the detailed catalog, Gravitino may not support some data types conversion for this specific catalog, for example,
Hive does not support `TIME` data type.

| Gravitino Type | Trino Type |
|----------------|------------|
Expand All @@ -36,8 +35,11 @@ All types of catalogs support the following data type conversions between Trino
| StringType | VARCHAR |
| VarcharType | VARCHAR |
| BinaryType | VARBINARY |
| TimestampType | TIMESTAMP |
| DateType | DATE |
| TimeType | TIME |
| TimestampType | TIMESTAMP |
| ArrayType | ARRAY |
| MapType | MAP |
| StructType | ROW |
| StructType | ROW |

For more about Trino data types, please refer to [Trino data types](https://trino.io/docs/current/language/types.html) and Gravitino data types, please refer to [Gravitino data types](../manage-metadata-using-gravitino.md#gravitino-table-column-type).

0 comments on commit 4a3eca5

Please sign in to comment.