Skip to content

Commit

Permalink
[#3058] improvement(client-python): Correct type specification of cre…
Browse files Browse the repository at this point in the history
…ate_fileset function (#3535)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

* Change the suggest type of `type` from `Catalog.Type` to
`Fileset.Type`

### Why are the changes needed?

Fix: #3508 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew :clients:client-python:test`

Co-authored-by: noidname01 <[email protected]>
Co-authored-by: TimWang <[email protected]>
  • Loading branch information
3 people authored May 23, 2024
1 parent 4513132 commit 5c7cf8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion clients/client-python/gravitino/catalog/fileset_catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def create_fileset(
self,
ident: NameIdentifier,
comment: str,
type: Catalog.Type,
type: Fileset.Type,
storage_location: str,
properties: Dict[str, str],
) -> Fileset:
Expand Down

0 comments on commit 5c7cf8b

Please sign in to comment.