Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] add multi PostgreSQL server version to CatalogPostgreSqlIT Integrate test to improve compatibility #1361

Closed
Tracked by #1335
FANNG1 opened this issue Jan 7, 2024 · 2 comments · Fixed by #1693
Closed
Tracked by #1335

[Improvement] add multi PostgreSQL server version to CatalogPostgreSqlIT Integrate test to improve compatibility #1361

FANNG1 opened this issue Jan 7, 2024 · 2 comments · Fixed by #1693
Assignees
@Clearvive
Labels
good first issue Good for newcomers improvement Improvements on everything
Milestone
Gravitino 0.4.0

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Jan 7, 2024 •
edited
Loading

What would you like to be improved?

CatalogPostgreSqlIT testing PostgreSQL with postgres:13, we'd better add 12,14,15,16 version

How should we improve?

No response
@FANNG1 FANNG1 added the improvement Improvements on everything label Jan 7, 2024
@FANNG1 FANNG1 changed the title [Improvement] add multi RDMS server version to JDBC Integrate test to improve compatibility [Improvement] add multi RDBMS server version to JDBC Integrate test to improve compatibility Jan 7, 2024
@FANNG1 FANNG1 added the good first issue Good for newcomers label Jan 7, 2024
@FANNG1 FANNG1 mentioned this issue Jan 7, 2024
Closed
12 tasks
@qqqttt123
Copy link
Contributor

Maybe we can split this into two issues.

@FANNG1
Copy link
Contributor Author

FANNG1 commented Jan 8, 2024

Maybe we can split this into two issues.

ok

@FANNG1 FANNG1 changed the title [Improvement] add multi RDBMS server version to JDBC Integrate test to improve compatibility [Improvement] add multi PostgreSQL server version to CatalogPostgreSqlIT Integrate test to improve compatibility Jan 8, 2024
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Jan 16, 2024
@FANNG1 FANNG1 mentioned this issue Jan 24, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 25, 2024
@FANNG1
[#1361] test(postgres-jdbc) support multi pg version in IT (#1693)
93e2af0 
### What changes were proposed in this pull request?
Use separate classes representing various PG versions.
junit5 doesn't support class-level ParameterizedTest. so use a separate
class.

### Why are the changes needed?
Test compatibility with various versions of PG.

Fix: #1361 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
existing IT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Clearvive Clearvive

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.4.0
Development

Successfully merging a pull request may close this issue.

[#1361] test(postgres-jdbc) support multi pg version in IT FANNG1/gravitino
4 participants
@jerryshao @FANNG1 @Clearvive @qqqttt123