Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Ensure the Trino connector is calling the correct methods of dropTable and purgeTable #1443

Closed
Tracked by #1436
mchades opened this issue Jan 11, 2024 · 0 comments · Fixed by #1705
Closed
Tracked by #1436

[Subtask] Ensure the Trino connector is calling the correct methods of dropTable and purgeTable #1443

mchades opened this issue Jan 11, 2024 · 0 comments · Fixed by #1705
Assignees
@diqiu50
Milestone
Gravitino 0.4.0

Comments

@mchades
Copy link
Contributor

mchades commented Jan 11, 2024

Describe the subtask

Ensure the Trino connector is calling the correct semantics of dropTable and purgeTable according to the discussion result in the parent issue.

Parent issue

#1436
@mchades mchades mentioned this issue Jan 11, 2024
Closed
4 tasks
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Jan 16, 2024
@FANNG1 FANNG1 mentioned this issue Jan 25, 2024
Merged
ch3yne pushed a commit to ch3yne/gravitino that referenced this issue Jan 29, 2024
@FANNG1 @ch3yne
[apache#1442] fix(jdbc-catalog): Ensure the JDBC catalogs implement t…
d6031d0 
…he correct semantics of dropTable and purgeTable (apache#1705)

### What changes were proposed in this pull request?
for JDBC catalog, use "DROP Table" for Gravitino drop table, and not
support Gravitino purge table

### Why are the changes needed?

Fix: apache#1442   
Fix: apache#1443 

### Does this PR introduce _any_ user-facing change?

yes, dropTable and purgeTable changed the semantics, I update the doc

### How was this patch tested?

exists UTs

coauther: @diqiu50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diqiu50 diqiu50

Labels
None yet
Projects
None yet
Milestone
Gravitino 0.4.0
3 participants
@jerryshao @diqiu50 @mchades