Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Audit information is empty of MYSQL schema #1767

Closed
danhuawang opened this issue Jan 29, 2024 · 1 comment
Closed

[Bug report] Audit information is empty of MYSQL schema #1767

danhuawang opened this issue Jan 29, 2024 · 1 comment
Assignees
@FANNG1
Labels
bug Something isn't working
Milestone
Gravitino 0.4.0

Comments

@danhuawang
Copy link
Contributor

Version

main branch

Describe what's wrong

截屏2024-01-29 21 04 07 截屏2024-01-29 21 04 20

Error message and/or stacktrace

N/A

How to reproduce

curl -X POST -H "Content-Type: application/json" -d '{"name":"s3","comment":"comment"}' http://localhost:8090/api/metalakes/test/catalogs/m11/schemas

{"code":0,"schema":{"name":"s3","properties":{"COLLATE":"utf8mb4_0900_ai_ci","CHARACTER SET":"utf8mb4"},"audit":{"creator":"anonymous","createTime":"2024-01-29T13:10:18.936Z"}}}%

curl http://localhost:8090/api/metalakes/test/catalogs/m11/schemas/s3

{"code":0,"schema":{"name":"s3","properties":{"COLLATE":"utf8mb4_0900_ai_ci","CHARACTER SET":"utf8mb4"},"audit":{}}}%

Additional context

No response
@danhuawang danhuawang added the bug Something isn't working label Jan 29, 2024
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Jan 30, 2024
@FANNG1
Copy link
Contributor

FANNG1 commented Jan 30, 2024 •
edited
Loading

Similar with #1499, What's the different is we could get schema comment in PG while couldn't get the schema comment in Mysql, see #1717

@FANNG1 FANNG1 mentioned this issue Jan 30, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 30, 2024
@FANNG1
[#1717] fix(jdbc-mysql): throw an exception if setting comment on MyS…
9215c37 
…QL database (#1784)

### What changes were proposed in this pull request?
throw a exception when user. set comment on MySQL database

### Why are the changes needed?

Fix: #1717 #1767 

### Does this PR introduce _any_ user-facing change?
yes, if user  set comment on MySQL database, will throw a exception.

### How was this patch tested?
add UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FANNG1 FANNG1

Labels
bug Something isn't working
Projects
None yet
Milestone
Gravitino 0.4.0
Development

No branches or pull requests
3 participants
@jerryshao @FANNG1 @danhuawang