Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] (trino-connector) Support system table catalog #2416

Closed
diqiu50 opened this issue Mar 4, 2024 · 4 comments
Closed

[FEATURE] (trino-connector) Support system table catalog #2416

diqiu50 opened this issue Mar 4, 2024 · 4 comments
Assignees
@diqiu50
Labels
feature New feature or request
Milestone
Gravitino 0.5.0

Comments

@diqiu50
Copy link
Contributor

diqiu50 commented Mar 4, 2024 •
edited
Loading

Describe the feature

Support the system table catalog to display all loaded catalog information in the Trino connector.
use can run this sql in Trino cli:

select * from gravition.system.catalog

the results are:

|   name     |  provider   |   properties                   |
-------------+------------ +--------------------------------+
|test.my-hive|     hive    | {"metastore_uril":"http:xxxx"} |

show create table gravition.system.catalog

the results are:

 CREATE TABLE gravitino.system.catalog (
    name varchar,
    provider varchar,
    properties map(varchar, varchar)
 )

Motivation

No response

Describe the solution

No response

Additional context

No response
@diqiu50 diqiu50 added the feature New feature or request label Mar 4, 2024
@diqiu50 diqiu50 added this to the Gravitino 0.5.0 milestone Mar 4, 2024
@diqiu50 diqiu50 self-assigned this Mar 4, 2024
@FANNG1
Copy link
Contributor

FANNG1 commented Mar 4, 2024

what's the difference? compared to SHOW CATALOGS

@jerryshao
Copy link
Contributor

I think system catalog is quite important for gravitino, so we should carefully design it, not just for trino.

@diqiu50
Copy link
Contributor Author

diqiu50 commented Mar 4, 2024

what's the difference? compared to SHOW CATALOGS

The Show catalog command only lists the catalog names.

@diqiu50
Copy link
Contributor Author

diqiu50 commented Mar 6, 2024

I have a design for the Gravitino System catalog
@jerryshao @FANNG1 @qqqttt123 @yuqi1129 @mchades Please take a reivew.
Gravitino System catalog

@diqiu50 diqiu50 changed the title [FEATURE] [trino-connector] Support system table catalog [FEATURE] (trino-connector) Support system table catalog Mar 13, 2024
@diqiu50 diqiu50 mentioned this issue Mar 13, 2024
Merged
coolderli pushed a commit to coolderli/gravitino that referenced this issue Apr 2, 2024
@diqiu50
[apache#2416] feat(trino-connector): Support system table catalog (ap…
7e4768c 
…ache#2522)

### What changes were proposed in this pull request?

Support the system table catalog to display all loaded catalog
information in the Trino connector.

### Why are the changes needed?

Fix: apache#2416 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

Add new UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diqiu50 diqiu50

Labels
feature New feature or request
Projects
None yet
Milestone
Gravitino 0.5.0
Development

No branches or pull requests
3 participants
@jerryshao @FANNG1 @diqiu50