Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] support UpdateColumnPosition in Altertable for spark connector #2494

Closed
caican00 opened this issue Mar 11, 2024 · 7 comments · Fixed by #2503
Closed

[Subtask] support UpdateColumnPosition in Altertable for spark connector #2494

caican00 opened this issue Mar 11, 2024 · 7 comments · Fixed by #2503
Labels
subtask Subtasks of umbrella issue

Comments

@caican00
Copy link
Collaborator

caican00 commented Mar 11, 2024 •
edited
Loading

Describe the subtask

please add related code to com.datastrato.gravitino.spark.catalogGravitinoCatalog.java, transfrom Spark TableChange to Gravitino TableChange, you could refer to #2458

  public Table alterTable(Identifier ident, TableChange... changes) throws NoSuchTableException {
    throw new NotSupportedException("Doesn't support altering table for now");
  }

Related Spark SQL should add to SparkIT.java, please refer https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-alter-table.html

Parent issue

#1227
@caican00 caican00 added the subtask Subtasks of umbrella issue label Mar 11, 2024
@caican00
Copy link
Collaborator Author

Hi @hiirrxnn i would like to confirm again that whether you are still working on the UpdateColumnPosition and UpdateColumnType mentioned in #1565 or not, and looking forward to your reply. Thank you

@caican00
Copy link
Collaborator Author

i will work on this.

@caican00 caican00 mentioned this issue Mar 11, 2024
Merged
caican00 added a commit to caican00/gravitino that referenced this issue Mar 11, 2024
@caican00
[apache#2494] feat(spark-connector): support UpdateColumnPosition in …
d6ee96b 
…Altertable for spark connector
@caican00 caican00 mentioned this issue Mar 11, 2024
Merged
@hiirrxnn
Copy link
Contributor

hiirrxnn commented Mar 11, 2024 •
edited
Loading

I was working on it ! Have you completed both the subtasks?

@caican00
Copy link
Collaborator Author

I was working on it ! Have you completed both the subtasks?

Hi @hiirrxnn i have created pull request for them. If you would like to keep doing it, I will close my pr.

@hiirrxnn
Copy link
Contributor

No problem , you can continue on your PR , I will find other issues to work on .

@caican00
Copy link
Collaborator Author

caican00 commented Mar 12, 2024 •
edited
Loading

No problem , you can continue on your PR , I will find other issues to work on .

Maybe you could follow up on this issue if you're interested in it. cc @hiirrxnn
#2498

@caican00
Copy link
Collaborator Author

No problem , you can continue on your PR , I will find other issues to work on .

Maybe you could follow up on this issue if you're interested in it. cc @hiirrxnn #2498

Hi @hiirrxnn this feature is expected in 0.5 which is released in 4.16, is the time suitable for you?

@caican00 caican00 mentioned this issue Mar 13, 2024
Closed
FANNG1 pushed a commit that referenced this issue Mar 14, 2024
@caican00
[#2494] feat(spark-connector): support UpdateColumnPosition in AlterT…
2bf2120 
…able for spark connector (#2503)

### What changes were proposed in this pull request?

Support UpdateColumnPosition in AlterTableCommand.

### Why are the changes needed?

Implement UpdateColumnPosition ops for Spark AlterTableCommand.

Fix: [#2494](#2494)

### Does this PR introduce _any_ user-facing change?
Yes, users can run the following commands to modify the table column
position using spark sql.

`ALTER TABLE StudentInfo CHANGE COLUMN col1 col1 string FIRST
`

### How was this patch tested?

New UTs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
2 participants
@caican00 @hiirrxnn