Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Unify MySQL container management with ContainerSuite #2807

Closed
Tracked by #2765
unknowntpo opened this issue Apr 4, 2024 · 0 comments · Fixed by #2813
Closed
Tracked by #2765

[Subtask] Unify MySQL container management with ContainerSuite #2807

unknowntpo opened this issue Apr 4, 2024 · 0 comments · Fixed by #2813
Assignees
@unknowntpo
Labels
subtask Subtasks of umbrella issue
Milestone
Gravitino 0.5.0

Comments

@unknowntpo
Copy link
Contributor

unknowntpo commented Apr 4, 2024 •
edited
Loading

Describe the subtask

Sub-issue of #2765,

Parent issue

#2765
@unknowntpo unknowntpo added the subtask Subtasks of umbrella issue label Apr 4, 2024
@unknowntpo unknowntpo mentioned this issue Apr 5, 2024
Closed
@unknowntpo unknowntpo changed the title [Subtask] Unify container management with ContainerSuit [Subtask] Unify container management with ContainerSuite Apr 6, 2024
This was referenced Apr 7, 2024
Merged
Closed
@unknowntpo unknowntpo changed the title [Subtask] Unify container management with ContainerSuite [Subtask] Unify MySQL container management with ContainerSuite Apr 7, 2024
mchades pushed a commit that referenced this issue Apr 20, 2024
@unknowntpo @yuqi1129
[#2807]: Improvement(IT): manage mysql containers in ContainerSuite (#…
6d598bc 
…2813)

### What changes were proposed in this pull request?

Manage MySQL containers (`mysql:5.7`, `mysql:8.0`) in `ContainerSuite`.
And each test class will create a unique database named
`TestClass.class.getSimpleName() + TestClass.class.hashCode()` for
testing.

### Why are the changes needed?

Because we want to share containers and manage their lifecycles in
`ContainerSuite`.

Fix: #2807 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested in integration tests.

---------

Co-authored-by: Qi Yu <[email protected]>
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 20, 2024
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@unknowntpo @yuqi1129 @diqiu50
[apache#2807]: Improvement(IT): manage mysql containers in ContainerS…
c1d4aa7 
…uite (apache#2813)

### What changes were proposed in this pull request?

Manage MySQL containers (`mysql:5.7`, `mysql:8.0`) in `ContainerSuite`.
And each test class will create a unique database named
`TestClass.class.getSimpleName() + TestClass.class.hashCode()` for
testing.

### Why are the changes needed?

Because we want to share containers and manage their lifecycles in
`ContainerSuite`.

Fix: apache#2807 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested in integration tests.

---------

Co-authored-by: Qi Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unknowntpo unknowntpo

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2807]: Improvement(IT): manage mysql containers in ContainerSuite unknowntpo/gravitino
2 participants
@jerryshao @unknowntpo