Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Support modify catalog properties like URI, username, password as they are currently immutable #4242

Closed
yuqi1129 opened this issue Jul 23, 2024 · 0 comments · Fixed by #4262
Closed

[Improvement] Support modify catalog properties like URI, username, password as they are currently immutable #4242

yuqi1129 opened this issue Jul 23, 2024 · 0 comments · Fixed by #4262
Assignees
@yuqi1129
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

We may encounter the following scenarios in the near future.

  • Create a catalog with the wrong URI but we can't correct it as the property is immutable, what we can do it to drop the catalog and create a new one, which is very verbose.
  • Due to business expansion and network refactor, users need to update the URI. For example, adding a new metastore server for a hive server and adding a new slave server for a MySQL cluster. The property is immutable and we have not supported drop catalog with cascade, if the catalog is not empty, we can't drop the catalog nor modify it, it's very embarrassing.

How should we improve?

Make the property mutable.
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Jul 23, 2024
@jerryshao jerryshao mentioned this issue Jul 31, 2024
Merged
yuqi1129 added a commit that referenced this issue Aug 4, 2024
@yuqi1129
[#4242][#2267][#3091] improvement(catalogs): Make some catalog proper…
4c4f15a 
…ty from immutable to mutable. (#4262)

### What changes were proposed in this pull request?

Change the properties of catalog from immutable to mutable. 

### Why are the changes needed?

This is to prevent users from assigning the property an incorrect value
by mistake.

Fix: #4242
Fix: #2267
Fix: #3091 

### Does this PR introduce _any_ user-facing change?

N/A.
### How was this patch tested?


UT & IT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
1 participant
@yuqi1129