-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Local cache should be turned off by default #4246
Comments
cc @jerryshao @jerqi |
For single instance deployment, local cache is still valid; I think the point is, when deploy it into multi-instances, should use external shared cache like a redis, instead of using local cache. |
In production environment, it is impossible to have only single instance deployed. If other companies deploy production Given that Gravitino currently does not support configuring external shared cache, local cache should be disabled by default to avoid data inconsistency in production environment. |
We're going to remove this local cache, as the number of roles will be significantly dropped after we refactor to use ownership mechanism. |
@lw-yang Do you like to submit a pull request to fix the issue? |
@jerqi Ok, I would like to fix it |
Gently ping. Will you continue this work? |
### What changes were proposed in this pull request? Remove role local cache ### Why are the changes needed? Fix: #4246 ### Does this PR introduce _any_ user-facing change? / ### How was this patch tested? exist ut Co-authored-by: Qi Yu <[email protected]>
### What changes were proposed in this pull request? Remove role local cache ### Why are the changes needed? Fix: #4246 ### Does this PR introduce _any_ user-facing change? / ### How was this patch tested? exist ut Co-authored-by: lwyang <[email protected]> Co-authored-by: Qi Yu <[email protected]>
What would you like to be improved?
In production environments, multiple Gravitino instances are typically deployed, which can lead to data inconsistency issues with local caching.
If data is deleted in one instance and then retrieved from another instance, the cache in the second instance may still contain the data.
In our scenario, we encountered an inconsistency issue, after deleting a role and then attempting to retrieve it, found the data still exists
Therefore, local caching should be disabled by default, allowing users to evaluate and choose whether to enable it.
Alternatively, a caching framework can be provided, allowing users to select the caching implementation, such as local caching or distributed caching.
How should we improve?
No response
The text was updated successfully, but these errors were encountered: