Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Refactor RangerSecurableObject class #5196

Closed
Tracked by #5115
xunliu opened this issue Oct 21, 2024 · 0 comments · Fixed by #5222
Closed
Tracked by #5115

[Improvement] Refactor RangerSecurableObject class #5196

xunliu opened this issue Oct 21, 2024 · 0 comments · Fixed by #5222
Assignees
@xunliu
Labels
improvement Improvements on everything
Milestone
Gravitino 0.7.0

Comments

@xunliu
Copy link
Member

xunliu commented Oct 21, 2024

What would you like to be improved?

Currently, RangerSecurableObject extends MetadataObject, but Ranger managers meta types different with Gravitino, for example, Ranger doesn't have METALAKE, ROLE, So we need to redefine RangerSecurableObject class.

How should we improve?

No response
@xunliu xunliu added the improvement Improvements on everything label Oct 21, 2024
@xunliu xunliu self-assigned this Oct 21, 2024
xunliu added a commit to xunliu/gravitino that referenced this issue Oct 22, 2024
@xunliu
[apache#5196] improve(auth-ranger): Refactor RangerSecurableObject class
5897bf1
This was referenced Oct 22, 2024
Merged
Open
@xunliu xunliu changed the title [Improvement] Redefine RangerSecurableObject class [Improvement] Refactor RangerSecurableObject class Oct 22, 2024
@xunliu xunliu closed this as completed in bea3934 Oct 23, 2024
@xunliu xunliu added this to the Gravitino 0.7.0 milestone Oct 28, 2024
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
@xunliu @mplmoknijb
[apache#5196] improve(auth-ranger): Refactor RangerSecurableObject cl…
69f6bdf 
…ass (apache#5222)

### What changes were proposed in this pull request?

1. Add `RangerMetadataObject` class.

### Why are the changes needed?

Currently, RangerSecurableObject extends MetadataObject, but Ranger
managers meta types different with Gravitino, for example, Ranger
doesn't have `METALAKE`, `ROLE`, So we need to Refactor
RangerSecurableObject class.

Fix: apache#5196

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI Passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xunliu xunliu

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.7.0
Development

Successfully merging a pull request may close this issue.

[#5196] improve(auth-ranger): Refactor RangerSecurableObject class xunliu/gravitino
1 participant
@xunliu