Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove AuthorizationPlugin single instance implement #5916

Closed
Tracked by #5774
xunliu opened this issue Dec 19, 2024 · 0 comments · Fixed by #5918
Closed
Tracked by #5774

[Improvement] Remove AuthorizationPlugin single instance implement #5916

xunliu opened this issue Dec 19, 2024 · 0 comments · Fixed by #5918
Assignees
@xunliu
Labels
0.8.0 Release v0.8.0 improvement Improvements on everything

Comments

@xunliu
Copy link
Member

xunliu commented Dec 19, 2024

What would you like to be improved?

Because each Catalog entity has an AuthorizationPlugin instance, So AuthorizationPlugin didn't need a single instance to implement, and a single instance let integration test early throw conflict.

How should we improve?

Remove AuthorizationPlugin single instance implement, use new AuthorizationPlugin object instead.
@xunliu xunliu added improvement Improvements on everything 0.8.0 Release v0.8.0 labels Dec 19, 2024
@xunliu xunliu self-assigned this Dec 19, 2024
@xunliu xunliu mentioned this issue Dec 19, 2024
Open
7 tasks
xunliu added a commit to xunliu/gravitino that referenced this issue Dec 19, 2024
@xunliu
[apache#5916] improve(auth): Remove AuthorizationPlugin single instan…
c19292f 
…ce implement
@xunliu xunliu mentioned this issue Dec 19, 2024
Merged
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this issue Dec 29, 2024
@xunliu @Abyss-lord
[apache#5916] improve(auth): Remove AuthorizationPlugin single instan…
1d16bda 
…ce implement (apache#5918)

### What changes were proposed in this pull request?

1. Remove AuthorizationPlugin single instance implement in the
`BaseAuthorizaiton.java`
2. Updatge ITs codes.

### Why are the changes needed?

Fix: apache#5916

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI Passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xunliu xunliu

Labels
0.8.0 Release v0.8.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5916] improve(auth): Remove AuthorizationPlugin single instance implement xunliu/gravitino
1 participant
@xunliu