[Bug report] UI should allow hyphen in fileset name #6399
Assignees
Labels
0.8.1
0.9.0
Release v0.9.0
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
|
@LauraXia123 cc |
jerryshao
added
good first issue
|
@mchades only fileset name or all the catalog name? |
all catalogs, you can test by API |
jerryshao
pushed a commit
that referenced
this issue
Feb 24, 2025
### What changes were proposed in this pull request? The validation schema for the `key` field within the `propItems` array was modified to allow hyphens in file names. The regular expression for the `key` was updated to: ```js /^[a-zA-Z_][a-zA-Z0-9_-]*$/ ``` ### Why are the changes needed? Fix: issue #6399 The UI was incorrectly rejecting file names containing hyphens when creating a fileset, even though hyphens were allowed in the name specification. The changes ensure that hyphens are properly validated as part of the file name. ### Does this PR introduce any user-facing change? Yes, this PR allows users to use hyphens in file names when creating a files ### How was this patch tested? The changes were tested by creating filesets with hyphens in the names via the UI, ensuring they were accepted correctly. --------- Co-authored-by: Qian Xia <[email protected]>
github-actions bot
pushed a commit
that referenced
this issue
Feb 24, 2025
### What changes were proposed in this pull request? The validation schema for the `key` field within the `propItems` array was modified to allow hyphens in file names. The regular expression for the `key` was updated to: ```js /^[a-zA-Z_][a-zA-Z0-9_-]*$/ ``` ### Why are the changes needed? Fix: issue #6399 The UI was incorrectly rejecting file names containing hyphens when creating a fileset, even though hyphens were allowed in the name specification. The changes ensure that hyphens are properly validated as part of the file name. ### Does this PR introduce any user-facing change? Yes, this PR allows users to use hyphens in file names when creating a files ### How was this patch tested? The changes were tested by creating filesets with hyphens in the names via the UI, ensuring they were accepted correctly. --------- Co-authored-by: Qian Xia <[email protected]>
|
@Pranaykarvi can you please leave a message here, so that I can assign the issue to you? |
|
jerryshao
pushed a commit
that referenced
this issue
Feb 24, 2025
### What changes were proposed in this pull request? The validation schema for the `key` field within the `propItems` array was modified to allow hyphens in file names. The regular expression for the `key` was updated to: ```js /^[a-zA-Z_][a-zA-Z0-9_-]*$/ ``` ### Why are the changes needed? Fix: issue #6399 The UI was incorrectly rejecting file names containing hyphens when creating a fileset, even though hyphens were allowed in the name specification. The changes ensure that hyphens are properly validated as part of the file name. ### Does this PR introduce any user-facing change? Yes, this PR allows users to use hyphens in file names when creating a files ### How was this patch tested? The changes were tested by creating filesets with hyphens in the names via the UI, ensuring they were accepted correctly. Co-authored-by: Pranay Kumar Karvi <[email protected]> Co-authored-by: Qian Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
main branch
Describe what's wrong
hyphen is allowed in the name spec:
gravitino/core/src/main/java/org/apache/gravitino/connector/capability/Capability.java
Lines 101 to 111 in d74ce36
Error message and/or stacktrace
How to reproduce
create a fileset by UI
Additional context
No response
The text was updated successfully, but these errors were encountered: