Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] In IcebergPropertiesConverter.java use of @VisibleForTesting constant #6529

Open
justinmclean opened this issue Feb 26, 2025 · 0 comments · May be fixed by #6571
Open

[Improvement] In IcebergPropertiesConverter.java use of @VisibleForTesting constant #6529

justinmclean opened this issue Feb 26, 2025 · 0 comments · May be fixed by #6571
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

In IcebergPropertiesConverter.java this line:
all.put(IcebergPropertiesConstants.ICEBERG_CATALOG_CACHE_ENABLED, "FALSE");

ICEBERG_CATALOG_CACHE_ENABLED is marked as @VisibleForTesting

How should we improve?

ICEBERG_CATALOG_CACHE_ENABLED is incorrectly marked as @VisibleForTesting?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
1 participant
@justinmclean