fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED

[Brijeshthummar02]

What changes were proposed in this pull request?

• Removed the incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED in IcebergPropertiesConstants.java.
• This constant is used in production code inside IcebergPropertiesConverter.java, so marking it as only for testing is incorrect.

Why are the changes needed?

• ICEBERG_CATALOG_CACHE_ENABLED is being used inside IcebergPropertiesConverter.java to set catalog properties.
• The @VisibleForTesting annotation suggests that the constant should only be accessed in test cases, which is misleading and incorrect.
• This fix ensures that the constant is correctly available for production use.

**Fix: #6529 **

Does this PR introduce any user-facing change?

• No user-facing changes. This is an internal improvement in the codebase.

[justinmclean]

The CI check is failing as we use Spotless to format our code to ensure consistency. You'll need to run ./gradlew :spark-connector:spark-common:spotlessApply and commit any changes it makes to fix this.

[Brijeshthummar02]

@justinmclean apart from this issue, i'm running through critical issue like not able to do commit from any ide vs nor github desktop i am not sure why its happening and never face this before the commit just runs and buffer not able to do anything further like sync or not showing GPG key pass, would be grateful if u have any tips related to it.

[justinmclean]

I don't think GitHub is having any issues right now. First off, I'd make sure you are trying to commit to your clone of the repo, not the ASF repo.

[Brijeshthummar02]

the clone repo which i forked not only this repo neither of my any repo works when i do commit it adds files, creates and pushes it but during commit msg it just buffer/loads not do anything neither complete the commit not cancel it.

when we do changes it generally shows to source control section it is not showing there too.

I AM STUCK.

[justinmclean]

I'm sorry you are having issues here; as it is hard to work out what might be wrong, I would suggest making a fresh clone and giving that a try.