New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1047] improvement(core): Fix the issue of StringIdentifier in metalake property #1162

Closed

yuqi1129 wants to merge 1 commit into main from issue_1047

Contributor

yuqi1129 commented Dec 14, 2023

What changes were proposed in this pull request?

Remove the stringId from metalake property map.

Why are the changes needed?

gravitino.identifier is generated internally and should not be visible to users.

Fix: #1047

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Existing UTs can cover it.


          Fix the issue of StringIdentifier

639db83

yuqi1129 closed this

github-actions bot commented Dec 14, 2023

Code Coverage Report

Overall Project	66.1% `-0.01%`	🟢
Files changed	96.39%	🟢

Module	Coverage
core	76.31% `-0.04%`	🟢

Files

Module	File	Coverage
core	StringIdentifier.java	98.13% `-1.25%`	🟢
	KvGarbageCollector.java	85.53%	🟢
	MetalakeManager.java	80.81% `-0.51%`	🟢

yuqi1129 deleted the issue_1047 branch

December 27, 2023 02:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet