[#1295] improvement(CI): separate trino image for CI and users #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqqttt123
reviewed
Jan 3, 2024
qqqttt123
reviewed
Jan 3, 2024
jerryshao
added
need backport
|
Please help to review it, thanks. |
|
@xunliu please help to review this PR, thanks. |
xunliu
reviewed
Jan 4, 2024
|
Any further comment on this PR @xunliu ? |
|
@xunliu |
@jerryshao Yes, This PR will also support |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
### What changes were proposed in this pull request? Remove the Gravitino connector from the Trino CI image. ### Why are the changes needed? In CI, we will mount the Gravitino connector to the Trino CI image to test the latest code base, so we can fully test our PR. Fix: #1295 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A --------- Co-authored-by: Jerry Shao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the Gravitino connector from the Trino CI image.
Why are the changes needed?
In CI, we will mount the Gravitino connector to the Trino CI image to test the latest code base, so we can fully test our PR.
Fix: #1295
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A