[#1311] bugfix(docker): Unable to run datastrato/trino Docker in AWS #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diqiu50 can you please help to review it. |
yuqi1129
reviewed
Jan 3, 2024
| @@ -3,5 +3,6 @@ | |||
| # This software is licensed under the Apache License version 2. | |||
| # | |||
| node.environment = docker | |||
| node.id = ffffffff-ffff-ffff-ffff-ffffffffffff | |||
There was a problem hiding this comment.
I recall that this line was added in the first edition. Please see #434
|
LGTM |
yuqi1129
added
branch-0.3
need backport
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
…1312) ### What changes were proposed in this pull request? Trino loss `node.id` configuration in the `node.properties` file. ``` root@ip-172-31-6-157:/# /usr/lib/trino/bin/run-trino + launcher_opts=(--etc-dir /etc/trino) + grep -s -q node.id /etc/trino/node.properties + launcher_opts+=("-Dnode.id=${HOSTNAME}") + exec /usr/lib/trino/bin/launcher run --etc-dir /etc/trino -Dnode.id=ip-172-31-6-157.ec2.internal OpenJDK 64-Bit Server VM warning: Option UseBiasedLocking was deprecated in version 15.0 and will likely be removed in a future release. Jan 02, 2024 2:33:42 PM io.airlift.log.Logger info INFO: Java version: 17.0.8.1 2024-01-02T14:33:42.382Z INFO main io.airlift.log.Logging Logging to stderr 2024-01-02T14:33:42.383Z INFO main Bootstrap Loading configuration 2024-01-02T14:33:42.645Z INFO main org.hibernate.validator.internal.util.Version HV000001: Hibernate Validator 8.0.0.Final 2024-01-02T14:33:43.052Z INFO main Bootstrap Initializing logging 2024-01-02T14:33:46.142Z ERROR main io.trino.server.Server Configuration is invalid ========== Errors: 1) Invalid configuration property node.id: is malformed (for class io.airlift.node.NodeConfig.nodeId) ========== ``` ### Why are the changes needed? Fix: #1311 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Manually test in the AWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Trino loss
node.idconfiguration in thenode.propertiesfile.Why are the changes needed?
Fix: #1311
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Manually test in the AWS