Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1317] fix(trino-connector): Support Fixed type conversion #1376

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

  1. Suppoort type 'Fixed' in Trino connector GeneralDataTypeTransformer

Why are the changes needed?

Fixed type is needed by Iceberg type.

Fix: #1317

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

IT.

### What changes were proposed in this pull request?

1. Suppoort type 'Fixed' in Trino connector `GeneralDataTypeTransformer`
 
### Why are the changes needed?

Fixed type is needed by Iceberg type.

Fix: #1317 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT.
@jerryshao jerryshao added cherry-pick need backport Issues that need to backport to another branch labels Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Code Coverage Report

Overall Project 66% -0.02% 🟢
Files changed 0% 🔴

Module Coverage
trino-connector 76.65% -0.19% 🔴
Files
Module File Coverage
trino-connector HiveDataTypeTransformer.java 9.09% 🟢
IcebergDataTypeTransformer.java 0% -34.48% 🔴

@jerryshao jerryshao merged commit 2b37f70 into branch-0.3 Jan 8, 2024
4 checks passed
@qqqttt123 qqqttt123 deleted the cherry-pick-branch-0.3-6544417cff52900751f6ddf244d653d1ec7ab517 branch January 8, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants