Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1755] fix(core): update guava from 31.1-jre to 32.1.3-jre #1807

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Jan 31, 2024

What changes were proposed in this pull request?

update guava from 31.1-jre to 32.1.3-jre

Why are the changes needed?

Fix: #1755

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

@FANNG1 FANNG1 marked this pull request as draft January 31, 2024 02:30
@jerryshao
Copy link
Contributor

Seems there're some issue in upgrading?

@FANNG1
Copy link
Contributor Author

FANNG1 commented Jan 31, 2024

There're some test failures in trino, @diqiu50 could you help to check it?

testAlterTable() {
    assertQueryFails(
        String.format("alter table %s add column if not exists c varchar", fullTableName1),
        format("This connector does not support adding columns"));
}

@FANNG1
Copy link
Contributor Author

FANNG1 commented Jan 31, 2024

with the help of @yuqi1129 , upgrade mockito to fix trino ut failure.

@FANNG1 FANNG1 marked this pull request as ready for review January 31, 2024 09:42
@FANNG1
Copy link
Contributor Author

FANNG1 commented Jan 31, 2024

test failure seems not related, run again.

MetalakePageTest > initializationError FAILED
    java.lang.RuntimeException: Webpage not loaded in 60 seconds.
        at com.datastrato.gravitino.integration.test.web.ui.utils.WebDriverManager.getWebDriver(WebDriverManager.java:53)
        at com.datastrato.gravitino.integration.test.web.ui.utils.AbstractWebIT.startUp(AbstractWebIT.java:22)

@jerryshao jerryshao merged commit 17b3406 into apache:main Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Guava 31.1-jre has two security issues, one is high
2 participants