[#1134] docs: Add user doc of expression #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
force-pushed
the
doc-expression
branch
from
2d1e5df to
080683f
Compare
jerryshao
reviewed
Feb 3, 2024
| The following is an example of creating a field reference expression, demonstrating how to create a reference for the `student` field. | ||
|
|
||
| <Tabs> | ||
| <TabItem value="Json" label="Json"> |
There was a problem hiding this comment.
is it Json or json for value? I see that below in Java it is value="java".
There was a problem hiding this comment.
After local testing, both can be rendered correctly.
This writing appears in other documents as well, should I change it to keep the styling consistent?
There was a problem hiding this comment.
I'm OK if it can be rendered correctly. If you want to unify them you can do it in another PR.
jerryshao
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add user doc of expression
Why are the changes needed?
Fix: #1134
Does this PR introduce any user-facing change?
no
How was this patch tested?
no need