[#1530] feat(spark-connector): support specifying scala version to build and test Gravitino #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to build and test Gravitino (apache#1582) ### What changes were proposed in this pull request? support specify scala versions, by two methods: 1. `gradle build -PscalaVersion=xx` 2. set `defaultScalaVersion` in gradle.properties method2 will be overwrite by method1 if both existing, and supports scala 2.12 for now. ### Why are the changes needed? spark hive connector just supports scala 2.12 Fix: apache#1530 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing UTs
FANNG1
changed the title
qqqttt123
approved these changes
Feb 7, 2024
|
@jerryshao , I plan to merge it if you don't oppose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support specify scala versions, by two methods:
gradle build -PscalaVersion=xxdefaultScalaVersionin gradle.propertiesmethod2 will be overwrite by method1 if both existing, and supports scala 2.12 for now.
Why are the changes needed?
spark hive connector just supports scala 2.12
Does this PR introduce any user-facing change? no
How was this patch tested?
existing UTs