[#2371] feat(API, meta): Add basic API and metadata module for messaging catalog #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YxAc @zhoukangcn can you help to review if you have time. :) |
mchades
changed the title
YxAc
reviewed
Mar 7, 2024
api/src/main/java/com/datastrato/gravitino/stream/DataLayout.java
Outdated
Show resolved
Hide resolved
YxAc
reviewed
Mar 7, 2024
api/src/main/java/com/datastrato/gravitino/stream/MessagingCatalog.java
Outdated
Show resolved
Hide resolved
YxAc
approved these changes
Mar 8, 2024
jerryshao
reviewed
Mar 8, 2024
api/src/main/java/com/datastrato/gravitino/messaging/TopicCatalog.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Mar 8, 2024
api/src/main/java/com/datastrato/gravitino/messaging/TopicCatalog.java
Outdated
Show resolved
Hide resolved
|
Don't forget to also update entity store related code to support storing topic to the entity store (both kv and relational). |
Okay, it will be done once we support a specific messaging catalog operation. |
jerryshao
reviewed
Mar 8, 2024
api/src/main/java/com/datastrato/gravitino/messaging/TopicChange.java
Outdated
Show resolved
Hide resolved
jerryshao
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add the
Topicmetadata support in Gravitino.Include the API and metadata module of
Topic.Why are the changes needed?
This is the first work of support MQ management in Gravitino.
Fix: #2371
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Add some UTs to test metadata, API test will be added when the implementation is achieved.