Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2448] feat(spark-connector): support alter table setProperty and removeProperty for spark-connector #2456

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

caican00
Copy link
Collaborator

@caican00 caican00 commented Mar 7, 2024

What changes were proposed in this pull request?

support add table property and remove table property for spark-connector in AlterTableCommand.

Why are the changes needed?

Implement setProperty and RemoveProperty ops for Spark AlterTableCommand.

Fix: #2448

Does this PR introduce any user-facing change?

Yes, users can run the following commands to modify the table properties using spark sql.

-- Alter TABLE property Using SET PROPERTIES
ALTER TABLE gravitino_catalog.dbx.tab1 SET TBLPROPERTIES ('key1' = 'value1');

-- DROP TABLE PROPERTIES
ALTER TABLE gravitino_catalog.dbx.tab1 UNSET TBLPROPERTIES ('key1');

How was this patch tested?

new uts.

@caican00 caican00 changed the title [#2448] feat(spark-connector): support table setProperty and removeProperty ops for spark-connector [#2448] feat(spark-connector): support table setProperty and removeProperty operations for spark-connector Mar 7, 2024
@caican00 caican00 changed the title [#2448] feat(spark-connector): support table setProperty and removeProperty operations for spark-connector [#2448] feat(spark-connector): support table setProperty and removeProperty for spark-connector Mar 7, 2024
@caican00
Copy link
Collaborator Author

caican00 commented Mar 7, 2024

Hi @FANNG1 all comments have been addressed. Could you help review it again?

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 7, 2024

LGTM, except one minor comment , @caican00 could you fix it?

@caican00
Copy link
Collaborator Author

caican00 commented Mar 7, 2024

LGTM, except one minor comment , @caican00 could you fix it?

This comment has been addressed.

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 7, 2024

LGTM, except one minor comment , @caican00 could you fix it?

This comment has been addressed.

LGTM, let's wait CI to finish

@FANNG1 FANNG1 changed the title [#2448] feat(spark-connector): support table setProperty and removeProperty for spark-connector [#2448] feat(spark-connector): support alter table setProperty and removeProperty for spark-connector Mar 7, 2024
@caican00 caican00 requested a review from FANNG1 March 7, 2024 11:38
@caican00
Copy link
Collaborator Author

caican00 commented Mar 7, 2024

I'm sorry about that I hit the request for review button by mistake.

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 7, 2024

I'm sorry about that I hit the request for review button by mistake.

don't be mind, build process is not triggered, I just trigger it manually.

@FANNG1 FANNG1 merged commit 7313c97 into apache:main Mar 7, 2024
7 checks passed
@FANNG1
Copy link
Contributor

FANNG1 commented Mar 7, 2024

@caican00 merged to main, thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] support add table property and remove table property for spark-connector
2 participants