-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2448] feat(spark-connector): support alter table setProperty and removeProperty for spark-connector #2456
Conversation
…moveProperty ops for spark-connector
...nnector/src/test/java/com/datastrato/gravitino/spark/connector/TestTransformTableChange.java
Outdated
Show resolved
Hide resolved
...nnector/src/main/java/com/datastrato/gravitino/spark/connector/catalog/GravitinoCatalog.java
Show resolved
Hide resolved
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java
Outdated
Show resolved
Hide resolved
Hi @FANNG1 all comments have been addressed. Could you help review it again? |
...nnector/src/main/java/com/datastrato/gravitino/spark/connector/catalog/GravitinoCatalog.java
Outdated
Show resolved
Hide resolved
LGTM, except one minor comment , @caican00 could you fix it? |
This comment has been addressed. |
LGTM, let's wait CI to finish |
I'm sorry about that I hit the request for review button by mistake. |
don't be mind, build process is not triggered, I just trigger it manually. |
@caican00 merged to main, thanks for your work. |
What changes were proposed in this pull request?
support add table property and remove table property for spark-connector in AlterTableCommand.
Why are the changes needed?
Implement setProperty and RemoveProperty ops for Spark AlterTableCommand.
Fix: #2448
Does this PR introduce any user-facing change?
Yes, users can run the following commands to modify the table properties using spark sql.
How was this patch tested?
new uts.