[#2414] improved(core): Make the unit tests for entity storage unified in the core module #2545
Conversation
| @@ -0,0 +1,71 @@ | |||
| /* | |||
| * Copyright 2023 Datastrato Pvt Ltd. | |||
There was a problem hiding this comment.
Only the package path was changed, so the original license was maintained.
| public static final String KV_STORE_PATH = | ||
| "/tmp/gravitino_kv_entityStore_" + UUID.randomUUID().toString().replace("-", ""); | ||
|
|
||
| private static final String JDBC_STORE_PATH = |
There was a problem hiding this comment.
Why do we need the storage path when using JDBC storage? Is the directory for storing H2 files there?
There was a problem hiding this comment.
H2 supports some connection modes, here we use the embedded mode to save the data, see: https://www.h2database.com/html/features.html#embedded_databases
core/src/test/java/com/datastrato/gravitino/storage/TestEntityStorage.java
Outdated
Show resolved
Hide resolved
| @@ -234,4 +236,164 @@ void testRemoveWithGCCollector() throws IOException, InterruptedException { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| void testRemoveWithGCCollector2() throws IOException, InterruptedException { | |||
There was a problem hiding this comment.
What's the difference between testRemoveWithGCCollector2 and the old one?
There was a problem hiding this comment.
The unit test testRemoveWithGCCollector2 was originally saved in the TestKvEntityStorage class. Since it has the same name as the unit test method in TestKvGarbageCollector, 1 and 2 are added to distinguish them. The test logic of testRemoveWithGCCollector1 and testRemoveWithGCCollector2 is slightly different, and there is no direct deletion here.
…unified in the core module (apache#2545) ### What changes were proposed in this pull request? The purpose of this PR is to unify some of the unit tests of the `Entity Store` to ensure that the same results can be obtained. ### Why are the changes needed? Fix: apache#2414 ### How was this patch tested? Using the modified unit tests. --------- Co-authored-by: xiaojiebao <[email protected]>
What changes were proposed in this pull request?
The purpose of this PR is to unify some of the unit tests of the
Entity Storeto ensure that the same results can be obtained.Why are the changes needed?
Fix: #2414
How was this patch tested?
Using the modified unit tests.