[#2525] fix(catalog-hive): Fix ClassNotFoundError in the Caffeine removal listener #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oval listener (#2600) ### What changes were proposed in this pull request? Close `HiveClientPool` before closing the class loader as the removal listener is asynchronous and can't make this guarantee. ### Why are the changes needed? It's bugs that need to be fixed. Fix: #2525 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? Test locally.
jerryshao
added
cherry-pick
need backport
Code Coverage Report
Files
|
yuqi1129
deleted the
cherry-pick-branch-0.4-f139f497777502853e6841163d74790f2dc15ae1
branch
yuqi1129
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Close
HiveClientPoolbefore closing the class loader as the removal listener is asynchronous and can't make this guarantee.Why are the changes needed?
It's bugs that need to be fixed.
Fix: #2525
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Test locally.