Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2348] Improvement(docs): Add user doc for relational entity store #2768

Merged
merged 16 commits into from
Apr 12, 2024

Conversation

xloya
Copy link
Contributor

@xloya xloya commented Apr 2, 2024

What changes were proposed in this pull request?

Add user documentation for relational entity store. Depends on #2584.

Why are the changes needed?

Fix: #2348

@xloya xloya changed the title [#2348] Improvement(docs): Add user docs for relational entity store [#2348] Improvement(docs): Add user doc for relational entity store Apr 2, 2024
@xloya xloya closed this Apr 2, 2024
@xloya xloya reopened this Apr 2, 2024
@xloya xloya force-pushed the add-user-docs-for-relational-backend branch from 1322f59 to b73b68a Compare April 8, 2024 02:58
@xloya
Copy link
Contributor Author

xloya commented Apr 8, 2024

@jerryshao @qqqttt123 @yuqi1129 Please take a look again of this, thanks.

@xloya
Copy link
Contributor Author

xloya commented Apr 8, 2024

@jerryshao @qqqttt123 @yuqi1129 Do you have any comment for this? Thanks.

xiaojiebao added 2 commits April 8, 2024 18:33
@jerryshao
Copy link
Contributor

I will help polish this. @xloya

@xloya
Copy link
Contributor Author

xloya commented Apr 8, 2024

I will help polish this. @xloya

Okay, thanks.

@xloya
Copy link
Contributor Author

xloya commented Apr 9, 2024

@jerryshao After fix the above comments, I have no more comments, thanks.

@jerryshao
Copy link
Contributor

@justinmclean would you help to review this PR, thanks.

@jerryshao jerryshao requested a review from justinmclean April 9, 2024 03:28
Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge it first. @justinmclean you can improve the docs by creating another PR.

@jerryshao jerryshao merged commit 08f9cc4 into apache:main Apr 12, 2024
9 checks passed
@xloya xloya deleted the add-user-docs-for-relational-backend branch June 20, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Add user doc for JDBC Backend
4 participants