Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2705] feat(core): Add the relational backend for User Entity #2850

Merged
merged 24 commits into from
Apr 20, 2024

Conversation

lw-yang
Copy link
Contributor

@lw-yang lw-yang commented Apr 9, 2024

What changes were proposed in this pull request?

add relational backend for User Entity

Why are the changes needed?

Fix: #2705

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

ut

@lw-yang lw-yang closed this Apr 9, 2024
@lw-yang lw-yang reopened this Apr 9, 2024
@lw-yang lw-yang closed this Apr 9, 2024
@lw-yang lw-yang reopened this Apr 9, 2024
@qqqttt123 qqqttt123 requested review from qqqttt123 and yuqi1129 April 9, 2024 12:19
@lw-yang
Copy link
Contributor Author

lw-yang commented Apr 10, 2024

@qqqttt123 @yuqi1129 please help review it

@yuqi1129
Copy link
Contributor

@qqqttt123
Do you have time to help review this PR? I have checked it , but I can't find any issues.

@lw-yang
Copy link
Contributor Author

lw-yang commented Apr 16, 2024

@qqqttt123 Could you help to review this

@lw-yang lw-yang changed the title [#2705] feat: add relational backend for User Entity [#2705] feat: add relational backend for User Entity (part-1) Apr 19, 2024
@qqqttt123
Copy link
Contributor

There are several points to modify.
First. we should delete authorization entities if we delete the metalake with non-cascade mode.
Second. we should update all the modified entities.

@qqqttt123 qqqttt123 changed the title [#2705] feat: add relational backend for User Entity (part-1) [#2705] feat: add relational backend for User Entity Apr 19, 2024
qqqttt123
qqqttt123 previously approved these changes Apr 19, 2024
Copy link
Contributor

@qqqttt123 qqqttt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qqqttt123 qqqttt123 changed the title [#2705] feat: add relational backend for User Entity [#2705] feat(core): Add relational backend for User Entity Apr 19, 2024
@qqqttt123 qqqttt123 changed the title [#2705] feat(core): Add relational backend for User Entity [#2705] feat(core): Add the relational backend for User Entity Apr 19, 2024
@lw-yang lw-yang closed this Apr 20, 2024
@lw-yang lw-yang reopened this Apr 20, 2024
@qqqttt123 qqqttt123 merged commit 008adb4 into apache:main Apr 20, 2024
22 checks passed
@qqqttt123
Copy link
Contributor

@lw-yang Merged to the master. Thanks.

qqqttt123 pushed a commit that referenced this pull request Apr 22, 2024
### What changes were proposed in this pull request?

add relational backend for Group Entity

[note]: wait for #2850 merged first

### Why are the changes needed?

Fix: #2851 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

ut

---------

Co-authored-by: yangliwei <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…pache#2850)

### What changes were proposed in this pull request?

add relational backend for User Entity

### Why are the changes needed?

Fix: apache#2705 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

ut

---------

Co-authored-by: yangliwei <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…ache#3031)

### What changes were proposed in this pull request?

add relational backend for Group Entity

[note]: wait for apache#2850 merged first

### Why are the changes needed?

Fix: apache#2851 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

ut

---------

Co-authored-by: yangliwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Add relational backend for User Entity
3 participants