Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5] feat(server): Add basic Jetty server support for Graviton #31

Merged
merged 12 commits into from
May 30, 2023

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

This PR proposes to add Jetty server support for Graviton.

Why are the changes needed?

The purpose of introducing Jetty as embedded web server is that:

  1. Jetty is a light-weighted web server that can be easily embedded into our project compared to Tomcat and other services.
  2. We basically don't want to introduce a bunch of Springboot related code to build our REST API. In that case, Jersey + Jetty would be the best choice.
  3. If later on the performance of Jetty cannot meet our requirements, we can shift to use other web servers instead.

Fix: #5

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Local manual test

@jerryshao jerryshao self-assigned this May 29, 2023
@jerryshao jerryshao requested a review from xunliu May 30, 2023 02:10
@jerryshao jerryshao marked this pull request as ready for review May 30, 2023 02:10
Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryshao jerryshao merged commit 58a15f4 into apache:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] Implement a service architecture for unified catalog
2 participants